-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cargo-dist to create binaries as release assets #1910
Comments
cargo-dist doesn't support cross compile. axodotdev/cargo-dist#74 Another project that might be helpful for CI settings. |
|
Yes In general, I'd be keen to embrace tools like that — we get their enhancements for free and reduce the scope of "non-core" code in PRQL. Ofc requires assessing whether the tool will grow or lose support, which can be difficult ahead of time. Also there are now ARM runners in preview for Linux. But not yet Windows, as you point out |
The problem with adopting dist is that it generates its own GHA workflow file, which would not be compatible with our release strategy and cache. |
Ah, that's a very good point; I hadn't thought of that. I had a quick look but didn't see a way to get around that in https://opensource.axo.dev/cargo-dist/book/ci/customizing.html It would be fine if we only ran |
We've had some good progress on creating binaries in #1883 & #762
In addition to those, we could also make lots of binaries with something like https://github.com/axodotdev/cargo-dist. I haven't looked at it in detail, but if it would let us do something like the "Assets" in https://github.com/BurntSushi/ripgrep/releases/tag/13.0.0 (screenshot below), that would be great.
The text was updated successfully, but these errors were encountered: