Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] add CI support #117

Closed
ringabout opened this issue Feb 7, 2022 · 3 comments · Fixed by #120
Closed

[Feature request] add CI support #117

ringabout opened this issue Feb 7, 2022 · 3 comments · Fixed by #120

Comments

@ringabout
Copy link

ringabout commented Feb 7, 2022

Important packages should have CI support, otherwise it make the Nim CI fragile

ref nim-lang/Nim#19499

@PMunch
Copy link
Owner

PMunch commented Feb 7, 2022

And what does CI support mean? What would have to be done? Please try to put a little more effort into creating a proper issue.

@ringabout
Copy link
Author

ringabout commented Feb 7, 2022

nimlsp is on the important packages, which means nimble test will be executed in the Nim repo CI by default. The CI has been broken for a week(Not sure whether it is a regression or the tnimlsp is broken)

2022-02-07T02:54:17.2941295Z /home/runner/work/Nim/Nim/pkgstemp/nimlsp/src/nimlsppkg/messages.nim(1, 8) Warning: imported and not used: 'messageenums' [UnusedImport]
2022-02-07T02:54:17.2941898Z /home/runner/work/Nim/Nim/pkgstemp/nimlsp/src/nimlsppkg/logger.nim(5) logger
2022-02-07T02:54:17.2942436Z /home/runner/work/Nim/Nim/lib/pure/logging.nim(575) newRollingFileLogger
2022-02-07T02:54:17.2942906Z /home/runner/work/Nim/Nim/lib/std/syncio.nim(764) open
2022-02-07T02:54:17.2943398Z Error: unhandled exception: cannot open: /tmp/nimlsp/nimlsp.log [IOError]
2022-02-07T02:54:17.2944177Z Error: execution of an external program failed: '/home/runner/work/Nim/Nim/pkgstemp/nimlsp/tests/tnimlsp '

And what does CI support mean? What would have to be done?

Add a GitHub action which execute nimble test or dedicated tests.

@PMunch
Copy link
Owner

PMunch commented Feb 7, 2022

Hmm, that error seems to be a matter of the CI not allowing reads in that folder. Or some of the changes @bung87 did somehow broke the log handling (it works when I run it locally though, so my guess is the CI). Should be a simple matter of telling the CI to use a different path for logging. NimLSP is unfortunately very poorly covered by tests. I have been meaning to write a LSP testing tool which would pose as an editor sending in requests and then verify the results it gets back from the server. And possibly add the ability to NimLSP to record sessions for replay later. However I haven't gotten around to it yet, but once I do a CI would definitely be a good idea. The tests running now are just checking the very basics.

@bung87 bung87 mentioned this issue Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants