-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] add CI support #117
Comments
And what does CI support mean? What would have to be done? Please try to put a little more effort into creating a proper issue. |
nimlsp is on the important packages, which means
Add a GitHub action which execute |
Hmm, that error seems to be a matter of the CI not allowing reads in that folder. Or some of the changes @bung87 did somehow broke the log handling (it works when I run it locally though, so my guess is the CI). Should be a simple matter of telling the CI to use a different path for logging. NimLSP is unfortunately very poorly covered by tests. I have been meaning to write a LSP testing tool which would pose as an editor sending in requests and then verify the results it gets back from the server. And possibly add the ability to NimLSP to record sessions for replay later. However I haven't gotten around to it yet, but once I do a CI would definitely be a good idea. The tests running now are just checking the very basics. |
Important packages should have CI support, otherwise it make the Nim CI fragile
ref nim-lang/Nim#19499
The text was updated successfully, but these errors were encountered: