Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non '_' version of multi-named keywords #207

Closed
ghaith opened this issue Jul 23, 2021 · 0 comments · Fixed by #213
Closed

Add support for non '_' version of multi-named keywords #207

ghaith opened this issue Jul 23, 2021 · 0 comments · Fixed by #213
Assignees
@ulmer-a
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
oscat

Comments

@ghaith
Copy link
Collaborator

ghaith commented Jul 23, 2021

In oscat, some of the FUNCTION_BLOCKS are defined as FUNCTIONBLOCKS, we should support this kind of keyword casing and report a diagnostic when encountered.

Candidates:

  • FUNCTION_BLOCK
  • VAR_INPUT
  • VAR_OUTPUT
  • VAR_GLOBAL
  • END_... all ending keywords
@ghaith ghaith added the enhancement New feature or request label Jul 23, 2021
@ghaith ghaith changed the title Add support for non '_' version of multi make keywords Add support for non '_' version of multi-named keywords Jul 23, 2021
@ghaith ghaith added this to the oscat milestone Jul 23, 2021
@ghaith ghaith added the good first issue Good for newcomers label Jul 27, 2021
@ulmer-a ulmer-a self-assigned this Jul 27, 2021
@ulmer-a ulmer-a mentioned this issue Jul 27, 2021
Merged
@ghaith ghaith moved this to Done in Next Jan 9, 2023
@ghaith ghaith added this to Next Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulmer-a ulmer-a

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Next
Status: Done
Milestone
oscat
Development

Successfully merging a pull request may close this issue.

Support multi-named keywords without underscore ulmer-a/rusty
2 participants
@ghaith @ulmer-a