Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows github runner broken #1241

Closed
ghaith opened this issue Jun 10, 2024 · 6 comments
Closed

Windows github runner broken #1241

ghaith opened this issue Jun 10, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@ghaith
Copy link
Collaborator

ghaith commented Jun 10, 2024

Describe the bug
Our tests currently fail on windows because of a change in the github runner. They run fine locally on a windows install.
I found an issue on the runner repo talking about a change in the C++ runtime, could be related but i can't be sure
actions/runner-images#10020
actions/runner-images#10004

We should find a more reliable way to run the windows tests that would not break with changes to the runtime.

@ghaith ghaith added the bug Something isn't working label Jun 10, 2024
@riederm
Copy link
Collaborator

riederm commented Jun 10, 2024

@PLC-lang/contributors
Can we discuss if we deactivate the windows build-action for the moment, and re-activate it when this issue was done?
Every PR fails atm.

@ghaith
Copy link
Collaborator Author

ghaith commented Jun 10, 2024

The windows action does not block the build it just reports a failure but you can still submit. I'm also fine with ignoring the test until we fix it however.
@volsa is checking it out at the moment.

@riederm
Copy link
Collaborator

riederm commented Jun 10, 2024

I find it disturbing that everything shows up as ❌ in the overview.
The repository's overall build status is also "failed"

@ghaith
Copy link
Collaborator Author

ghaith commented Jun 10, 2024

I created a PR #1242 that splits the workflows and disabled windows for now. Feel free to submit it and we can enable it again when the issues are fixed

@volsa
Copy link
Member

volsa commented Jun 10, 2024

FYI I wasn't able to find a solution, but as far as I can tell GitHub / Microsoft unofficially acknowledged the issue and are working on a hotfix? Personally I would just wait this out and see if the issue fixes itself in a few days.

@ghaith
Copy link
Collaborator Author

ghaith commented Jun 13, 2024

The fix is deployed, builds now run again

@ghaith ghaith closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants