Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modmails with too large an attachment are not handled #249

Open
R3TRO04 opened this issue Mar 25, 2022 · 1 comment
Open

Modmails with too large an attachment are not handled #249

R3TRO04 opened this issue Mar 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@R3TRO04
Copy link

R3TRO04 commented Mar 25, 2022

Description

If the server Sam is running on does not have enough server boosts, an exception is thrown that is not handled. Sam never informs the user what happened to the modmail.

What we need to change

The exception should be caught and then the sender should be informed that the modmail was not sent because the attachment was too big.

@PKlempe PKlempe added the bug Something isn't working label Mar 26, 2022
@PKlempe
Copy link
Owner

PKlempe commented Mar 26, 2022

So if I understand this correctly, the problem is that if a user has Discord Nitro and the server on which the bot is running doesn't have enough Server Boosts, the bots upload limit is 8MB while the user probably has 50 or 100MB (depending on which kind of Nitro he bought). This should mean that a user is able to invoke the modmail command with a larger file attachment, but SAM can't post the message in the configured modmail channel because he isn't allowed to upload the file. Interesting... 🤔

I think SAM should at least inform the user about this problem and suggest using a link from a file sharing plattform instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants