This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Fixed formula/formatting bug when removing rows #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $cell = $pSheet->getCell($cellID); | ||
| $cellIndex = PHPExcel_Cell::columnIndexFromString($cell->getColumn()); | ||
| if ($cellIndex-1 + $pNumCols < 0) { |
There was a problem hiding this comment.
Added this new check to stay in bounds.
MarkBaker
pushed a commit
that referenced
this pull request
Oct 28, 2012
Fixed formula/formatting bug when removing rows
|
Thanks for the fix, very useful |
|
Thanks for the merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When columns were being added/removed, empty cells were being overwritten with blank cells that specified the default format, effectively overwriting the column format.
Also, when removing columns, there was an order-of-operation bug that caused some formulas to be rewritten incorrectly.