Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new traits to release dashboard #336

Closed
fyvon opened this issue Mar 13, 2024 · 1 comment · Fixed by #342
Closed

Add new traits to release dashboard #336

fyvon opened this issue Mar 13, 2024 · 1 comment · Fixed by #342
Assignees
Labels
enhancement New feature or request

Comments

@fyvon
Copy link
Member

fyvon commented Mar 13, 2024

No description provided.

@fyvon fyvon added the enhancement New feature or request label Mar 13, 2024
@fyvon fyvon self-assigned this Mar 13, 2024
@ens-lgil
Copy link
Member

You could use the method written here as a starting point: https://github.com/PGScatalog/PGS_Catalog/blob/master/release/scripts/run_post_processing_script.py#L79
However I am not sure that the line if count_scores == 1: is correct, mainly if more than one new score is mapped to a new trait.
Furthermore, this method is used after the cleanup of the DB.

One thing we could do is to fetch the list of traits from the new release and check if they are mapped to any scores released before this new release

@fyvon fyvon linked a pull request Mar 26, 2024 that will close this issue
@fyvon fyvon closed this as completed in #342 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants