Introduce a new move qualifier #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGG106
added a commit
that referenced
this pull request
Feb 12, 2024
* disable search output when benching Bench 6920775 * restore search output after a bench to accomodate some no ones Bench: 6920775 * Introduce a new move qualifier (#336) Bench: 6920775 * code improvements Bench: 6920775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new move qualifier in the form of isTactical, this is a shorthand to check if the move is neither a capture nor a promo (doesn't matter if it's a capturing promo or a quiet one). This functionally replaces what isQuiet currently does and lets isQuiet have the more intuitive function of just checking if the move is a capture or not.
Since it's a 1:1 substitute to the old isQueit it means we aren't using isQuiet anywhere anymore (for now), some further testing might be warranted on if there's some Elo to be squeezed from that.
No functional change.
Bench: 6920775