Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PMP JSON contents #869

Closed
lee1043 opened this issue Sep 6, 2022 · 9 comments · Fixed by #851 or #892
Closed

Simplify PMP JSON contents #869

lee1043 opened this issue Sep 6, 2022 · 9 comments · Fixed by #851 or #892
Assignees

Comments

@lee1043
Copy link
Contributor

lee1043 commented Sep 6, 2022

Current PMP output json files have heavy contents (e.g., Mean clim, MoV). In effort to reduce the file size for regular online archive, one possibility is to not include "YAML" and "script" as default.

I think this could be handled by revising base.py in pcmdi_metrics/io directory, maybe by adding if statement for this line of the code, so storing YAML info can be optional.

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 6, 2022

@acordonez would you mind helping on this when you have time?

@acordonez
Copy link
Collaborator

@lee1043 Yes I'll start taking a look at this

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 22, 2022

@acordonez, I got this handled in this commit, as a part of PR for cloud metric, so no worries.

I am yet to test its influence to the cmec flag, presume there should be no impact. @acordonez any thoughts?

@lee1043 lee1043 self-assigned this Sep 22, 2022
@lee1043 lee1043 linked a pull request Sep 22, 2022 that will close this issue
@acordonez
Copy link
Collaborator

@lee1043 It shouldn't have any effect on the cmec flag operation, but I'll give it a test

@acordonez
Copy link
Collaborator

I tried out the monsoon_wang and enso drivers with the new changes. They don't include the YAML or scripts by default. The enso flag worked fine with monsoon_wang.

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 22, 2022

@acordonez thank you for checking this. I believe you meant "cmec" flag worked fine with monsoon_wang and enso driver, is that right?

@acordonez
Copy link
Collaborator

@lee1043 I don't think we've implemented the "cmec" flag with enso driver - I get an "unrecognized argument" error when I add it in, and I don't see it in the driver code.

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 22, 2022

@acordonez right, thanks for clarifying. I just got confused because you mentioned enso in your comment

I tried out the monsoon_wang and enso drivers with the new changes. They don't include the YAML or scripts by default. The enso flag worked fine with monsoon_wang.

@acordonez
Copy link
Collaborator

@lee1043 Oh I see, my brain kept skipping over my own typo! Yes, the cmec flag.

@lee1043 lee1043 linked a pull request Oct 26, 2022 that will close this issue
@lee1043 lee1043 linked a pull request Dec 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants