-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify PMP JSON contents #869
Comments
@acordonez would you mind helping on this when you have time? |
@lee1043 Yes I'll start taking a look at this |
@acordonez, I got this handled in this commit, as a part of PR for cloud metric, so no worries. I am yet to test its influence to the cmec flag, presume there should be no impact. @acordonez any thoughts? |
@lee1043 It shouldn't have any effect on the cmec flag operation, but I'll give it a test |
I tried out the monsoon_wang and enso drivers with the new changes. They don't include the YAML or scripts by default. The enso flag worked fine with monsoon_wang. |
@acordonez thank you for checking this. I believe you meant "cmec" flag worked fine with monsoon_wang and enso driver, is that right? |
@lee1043 I don't think we've implemented the "cmec" flag with enso driver - I get an "unrecognized argument" error when I add it in, and I don't see it in the driver code. |
@acordonez right, thanks for clarifying. I just got confused because you mentioned enso in your comment
|
@lee1043 Oh I see, my brain kept skipping over my own typo! Yes, the cmec flag. |
Current PMP output json files have heavy contents (e.g., Mean clim, MoV). In effort to reduce the file size for regular online archive, one possibility is to not include "YAML" and "script" as default.
I think this could be handled by revising
base.py
inpcmdi_metrics/io
directory, maybe by addingif
statement for this line of the code, so storing YAML info can be optional.The text was updated successfully, but these errors were encountered: