You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"... Note that the paper documenting this just went under review, so it is possible that reviewers will demand that we change our metric. But it is a simple RMSE, so there is nothing really complicated. (I will present the science of this at the meeting on Thursday.)
The primary code is main.py. Please ignore all my awful coding and inability to optimize things. You will note that the code begins by creating xmls that point to the end-user’s local netcdf files. I’m sure the PMP handles this a bit differently. And probably this could just be replaced by xarray.open_mfdataset("path/files/*.nc", combine='by_coords'), skipping over the whole xml-generation step. I haven’t yet taking the plunge into xarray, so I only know this from the xCDAT doc that Jiwoo and others have put together (thanks for that!)."
The text was updated successfully, but these errors were encountered:
There are a few things that could be written out to the JSON file. You have two of them already, the ECS and the cloud feedback RMSE. Additionally the total cloud feedback (the last element of “assessed”) and the climatological cloud error metric (referred to as “E_NET”) should be included. These are the fields plotted in these figures (GFDL is highlighted as an example):
I think what this means on your end is instead of returning just RMSE6[m] and ECS6[m] from dataviz.make_all_figs(), you should additionally return E_NET6[m] and assessed6[m,-1].
So I might suggest returning E_NET6[m], RMSE6[m], assessed6[m,-1], ECS6[m] from dataviz.make_all_figs()
And then in cloud_feedback_driver.py you would have:
climo_cld_rmse, cld_fbk_rmse, tot_cld_fbk, ecs = dataviz.make_all_figs()
If we wanted to also write out all the individual assessed cloud feedbacks, that could also be done. That would help people rationalize the RMSE score that they got. These data reside in the “assessed” variable. I don’t really see a good reason to not do this, as ultimately it is just another set of scalars that can be reported in the JSON (but please let me know if there is a reason). In this case, rather than just returning the last element of assessed6, you’d return the entire vector: assessed6[m,:].
Implement @mzelinka's cloud metric.
Message from @mzelinka:
"... Note that the paper documenting this just went under review, so it is possible that reviewers will demand that we change our metric. But it is a simple RMSE, so there is nothing really complicated. (I will present the science of this at the meeting on Thursday.)
The primary code is main.py. Please ignore all my awful coding and inability to optimize things. You will note that the code begins by creating xmls that point to the end-user’s local netcdf files. I’m sure the PMP handles this a bit differently. And probably this could just be replaced by xarray.open_mfdataset("path/files/*.nc", combine='by_coords'), skipping over the whole xml-generation step. I haven’t yet taking the plunge into xarray, so I only know this from the xCDAT doc that Jiwoo and others have put together (thanks for that!)."
The text was updated successfully, but these errors were encountered: