Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is "wsu:" namespace hardcoded? Any standard which enforces this namespace usage? #87

Closed
nikolaybobrovskiy opened this issue Feb 10, 2020 · 5 comments
Closed

Why is "wsu:" namespace hardcoded? Any standard which enforces this namespace usage? #87

nikolaybobrovskiy opened this issue Feb 10, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@nikolaybobrovskiy
Copy link

nikolaybobrovskiy commented Feb 10, 2020 •
edited
Loading

https://github.com/difi/Oxalis-AS4/blob/b6965860835ab19ad4c365aabe0c5ec6850b4777/src/main/java/no/difi/oxalis/as4/util/SOAPHeaderParser.java#L82

Because of this, for example, this content is failed to be parsed correctly:

p4:Id="cert-efbaa4b8-5ead-405e-a086-54a18db30750" xmlns:p4="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd"
@FrodeBjerkholt
Copy link
Contributor

Good question - I will look into it.

@nikolaybobrovskiy nikolaybobrovskiy changed the title Why "wsu:" namespace is hardcoded? Any standard which enforces this namespace usage? Why is "wsu:" namespace hardcoded? Any standard which enforces this namespace usage? Feb 10, 2020
@FrodeBjerkholt
Copy link
Contributor

I guess that a better implementation would be something like this:

if (bstElem.getAttributeNS("http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd", "Id").equals(refUri)) {

@FrodeBjerkholt FrodeBjerkholt added the enhancement New feature or request label Feb 10, 2020
@FrodeBjerkholt
Copy link
Contributor

I will fix it in the next release - Most likely this Thursday.

@FrodeBjerkholt
Copy link
Contributor

I have a fix ready, but I have to wait with the release for tomorrow.

@FrodeBjerkholt
Copy link
Contributor

Fixed in 4.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikolaybobrovskiy @FrodeBjerkholt