From f82a3d148fb8bc4aa15257c3eb75406e1e9bcf0c Mon Sep 17 00:00:00 2001 From: Owen Edwards Date: Mon, 7 Mar 2016 15:25:12 -0500 Subject: [PATCH] @OwenEdwards fixed menu closing on ios, specifically ipad. closes #3158 --- CHANGELOG.md | 1 + src/css/components/menu/_menu-popup.scss | 2 +- src/js/player.js | 5 +++++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e28629a71..390335e012 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ CHANGELOG * @BrandonOCasey updated text track unit tests to use full es6 syntax ([view](https://github.com/videojs/video.js/pull/3148)) * @defli added missing var to sandbox index.html example ([view](https://github.com/videojs/video.js/pull/3155)) * @defli fixed typo and updated Turkish translations ([view](https://github.com/videojs/video.js/pull/3156)) +* @OwenEdwards fixed menu closing on ios, specifically ipad ([view](https://github.com/videojs/video.js/pull/3158)) -------------------- diff --git a/src/css/components/menu/_menu-popup.scss b/src/css/components/menu/_menu-popup.scss index 4387780e84..6eb4722b1a 100644 --- a/src/css/components/menu/_menu-popup.scss +++ b/src/css/components/menu/_menu-popup.scss @@ -19,7 +19,7 @@ max-height: 15em; } -.vjs-menu-button-popup:hover .vjs-menu, +.vjs-workinghover .vjs-menu-button-popup:hover .vjs-menu, .vjs-menu-button-popup .vjs-menu.vjs-lock-showing { display: block; } diff --git a/src/js/player.js b/src/js/player.js index b32003b3fb..ae72ca1136 100644 --- a/src/js/player.js +++ b/src/js/player.js @@ -196,6 +196,11 @@ class Player extends Component { // this.addClass('vjs-touch-enabled'); // } + // iOS Safari has broken hover handling + if (!browser.IS_IOS) { + this.addClass('vjs-workinghover'); + } + // Make player easily findable by ID Player.players[this.id_] = this;