Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-10868 Updated exportToExcel to use saveAsync #421

Merged
merged 3 commits into from
Jul 2, 2024
Merged

ROU-10868 Updated exportToExcel to use saveAsync #421

merged 3 commits into from
Jul 2, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Jun 30, 2024

This PR will update the framework method exportToExcel to use book.saveAsync.

What was happening

  • With JSZip update to version 3.10.1 the method book.save is not supported by Wijmo Flexgrid since they only support it until version 2.5.0
  • Some gulp and eslint dependencies were not compatible.

What was done

  • Updated the framework method exportToExcel to use book.saveAsync.
  • Updated dev dependencies

Test Steps

  1. Go to a screen containing a Data Grid instance
  2. Check the resources for JSZip v3.10.1
  3. Right-click on a cell
  4. Click Export to Excel
  5. Checked that it continues to work as expected

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems
  • requires new sample page in OutSystems

Updated exportToExcel to use saveAsync since with JSZip update is the one that is supported by Wijmo Flexgrid
@gnbm gnbm added the enhancement New feature or request label Jun 30, 2024
@gnbm gnbm added dependencies chore and removed enhancement New feature or request labels Jun 30, 2024
@gnbm gnbm changed the title ROU-10868: Updated exportToExcel to use saveAsync ROU-10868 Updated exportToExcel to use saveAsync Jun 30, 2024
Copy link

sonarcloud bot commented Jun 30, 2024

@gnbm gnbm marked this pull request as ready for review July 1, 2024 13:24
@gnbm gnbm requested a review from a team as a code owner July 1, 2024 13:24
@gnbm gnbm merged commit 1564f92 into dev Jul 2, 2024
9 of 13 checks passed
@gnbm gnbm deleted the ROU-10868 branch July 2, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants