Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4659: Open SetColumnFilterOptions to work with more column types #386

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Dec 19, 2023

This PR is for open SetColumnFilterOptions to work with more column types

What was done

  • Add the capability to set column filter options to work with Number, Currency, Date and DateTime.
    • Edited the setColumnFilterOptions method to consider Number, Currency, Date and DateTime column types.
    • Edited the Error Message.
  • Added toLowerCase() when checking if the "ExternalLink" options from the Action column is a binding or an external link.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Dec 19, 2023
BenOsodrac
BenOsodrac previously approved these changes Dec 19, 2023
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@OS-giulianasilva OS-giulianasilva merged commit 76a88e8 into dev Dec 19, 2023
13 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4659 branch December 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants