Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-4486: changes required to expand the usage of setColumnFilterOptions method #383

Closed
wants to merge 3 commits into from
Closed

ROU-4486: changes required to expand the usage of setColumnFilterOptions method #383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91a6da1
Adding columns allowed for setColumnFilterOptions method
rugoncalves Nov 28, 2023
517dc25
Merge branch 'dev' into ROU-4486
OS-giulianasilva Dec 18, 2023
0657ae3
Change ColumnFilter ErrorMessage
OS-giulianasilva Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/Providers/DataGrid/Wijmo/Features/ColumnFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,17 @@ namespace Providers.DataGrid.Wijmo.Feature {
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Text ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Dropdown
OSFramework.DataGrid.Enum.ColumnType.Dropdown ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Checkbox ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Currency ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Date ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.DateTime ||
column.columnType ===
OSFramework.DataGrid.Enum.ColumnType.Number
) {
// this column will have both filter types
this.changeFilterType(
Expand All @@ -369,7 +379,7 @@ namespace Providers.DataGrid.Wijmo.Feature {
).valueFilter.maxValues = maxVisibleOptions;
} else {
throw new Error(
`The SetColumnFilterOptions client action can only be applied to Text or Dropdowncolumns.`
`The SetColumnFilterOptions client action can only be applied to Text, Number, Currency, Dropdown, Checkbox, Date, DateTime Columns.`
);
}
} else {
Expand Down
Loading