Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4571: Set custom tooltip on ColumnGroup #377

Merged
merged 5 commits into from
Oct 13, 2023
Merged

ROU-4571: Set custom tooltip on ColumnGroup #377

merged 5 commits into from
Oct 13, 2023

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is to fix the issue with the custom tooltip when used in a Grid with Column Group

What was happening

  • When using the custom tooltip in a Grid with Column Group, the tooltip was not placed in the right column.
  • The issue was that the column index returned by Wijmo cannot be used to get the column on the OSDG side when using a Grid with Column Group, because Wijmo does not consider the Column Group as it is done on OSDG side.
  • Example: The "Price Tooltip" should have been placed in the Price column instead of the Stock column.
    groupcolumntooltipissue

What was done

  • Changed the Tooltip _setHeaderTooltip method to use the binding instead of the column index to get the column configs.
  • Created a new file to place the constants used in the file
  • Added a method to set the Column Group header tooltip
  • Exposed the tooltip as a Data Grid feature
    • This is necessary so the developer can use the new setColumnGroupHeaderTooltip method

Test Steps

  1. Add a Grid with a Column Group
  2. Add a custom tooltip to one of the columns
  3. In runtime, check that the custom tooltip is placed in the correct column.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

- Fix bug when using a custom tooltip in a Grid with Column Group
- Created a new file to place the constants used in the file
- Added a method to set the Column Group header tooltip
- This is necessary so the developer can use the new setColumnGroupHeaderTooltip method
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Oct 13, 2023
bmarcelino-fe
bmarcelino-fe previously approved these changes Oct 13, 2023
BenOsodrac
BenOsodrac previously approved these changes Oct 13, 2023
src/OSFramework/DataGrid/Feature/ExposedFeatures.ts Outdated Show resolved Hide resolved
src/OSFramework/DataGrid/Feature/ITooltip.ts Outdated Show resolved Hide resolved
src/Providers/DataGrid/Wijmo/Features/FeatureBuilder.ts Outdated Show resolved Hide resolved
src/Providers/DataGrid/Wijmo/Features/ToolTip.ts Outdated Show resolved Hide resolved
src/Providers/DataGrid/Wijmo/Features/ToolTip.ts Outdated Show resolved Hide resolved
src/Providers/DataGrid/Wijmo/Features/ToolTip.ts Outdated Show resolved Hide resolved
src/Providers/DataGrid/Wijmo/Helper/Constants.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @OS-giulianasilva!!!

@OS-giulianasilva OS-giulianasilva merged commit 73d4c24 into dev Oct 13, 2023
13 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4571 branch October 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants