Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4439: Issue with dropdown column when deleting multiple cells #374

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is to fix the issue with the dropdown column when deleting multiple cells and undoing the action.

What was happening

  • When deleting multiple cells of dropdown cells with dropdown dependency and undoing it, not all the child cells were being restored to their previous value.
  • This was happening because not all the undo actions were being registered as children of the first undo action.

What was done

  • Instead of trying to find the action related to the parent dropdown action for each child in the undo stack, we now search for the action related to the first parent cell selected for all the child dropdown actions.

Test Steps

  1. Go to a test page that contains a Grid implemented with dropdown columns with dependency
  2. Select multiple cells of the parent dropdown column
  3. Press Delete
  4. Press Ctrl+Z to undo
  5. Check that all the cells from the parent and child dropdown return to their original values.

Screenshots

dropdownDependencyFix

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

- When deleting multiple cells of dropdown cells with dropdown dependency and undoing it, not all the child cells were being restored to their previous value.
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Aug 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OS-giulianasilva OS-giulianasilva merged commit de55477 into dev Aug 25, 2023
12 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4439 branch August 25, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants