Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-4182: New Image Column #369

Merged
merged 3 commits into from
Aug 21, 2023
Merged

ROU-4182: New Image Column #369

merged 3 commits into from
Aug 21, 2023

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is for implementing the new image column.

What was done

  • Added ImageColumn class
  • Added ImageColumnClick event
  • Added ColumnConfigImage
  • Changed ActionColumnFactory to CellTemplateFactory

Test Steps

  1. Go to a page with an Image Column
  2. Check if the image is displayed
  3. Check if the ClickEvent is fired when the image is clicked
  4. Check if the image's alt-text and aria-label correspond to the AltTextFixed or AltTextFromBinding

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-giulianasilva
Implement image column
78ae8b8 
- Added ImageColumn class
- Added ImageColumnClick event
- Added Column Config Image
- Changed ActionColumnFactory to CellTemplateFactory
@OS-giulianasilva
Update ColumnConfigImage
4955d14
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OS-giulianasilva OS-giulianasilva merged commit 0400e09 into dev Aug 21, 2023
11 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4182 branch August 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joselrio joselrio joselrio approved these changes

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd approved these changes

@gnbm gnbm Awaiting requested review from gnbm

@BenOsodrac BenOsodrac Awaiting requested review from BenOsodrac

@bmarcelino-fe bmarcelino-fe Awaiting requested review from bmarcelino-fe

@rugoncalves rugoncalves Awaiting requested review from rugoncalves

Assignees
No one assigned
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OS-giulianasilva @joselrio @JoaoFerreira-FrontEnd