Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4472: Improve the SetColumnWordWrap to make the DynamicHeight being applied to the header #367

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Jul 28, 2023

This PR is to improve the SetColumnWordWrap to make the DynamicHeight applied to the header.

What was happening

  • When setting DynamicHeight in the client action SetColumnWordWrap it only applies to the cells with data, not to the headers:

ROU-4472_Before

What was done

  • Now, when setting DynamicHeight = True the client action SetColumnWordWrap the header will also receive the same behaviour.

Test Steps

  1. Go to test page APIStyling
  2. Reduce the Product Name column width
  3. Click on “SetColumnWordWrap“
  4. Checked that both data cells and header have the height adapted to their content

Screenshots

ROU-4472_AfterImprov

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

gnbm added 3 commits July 27, 2023 11:59
- Improved setColumnWordWrap to apply also to headers.
- Incremented the version to 2.13.0
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Jul 28, 2023
@gnbm gnbm marked this pull request as ready for review July 31, 2023 20:54
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this only enter together with the other task?

docs/assets/highlight.css Show resolved Hide resolved
docs/assets/search.js Show resolved Hide resolved
docs/assets/style.css Show resolved Hide resolved
Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon discussion, let's move forward.

@gnbm gnbm merged commit 032eed0 into dev Aug 1, 2023
9 checks passed
@gnbm gnbm deleted the ROU-4472 branch August 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants