Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4386: ContextMenu - avoid raising twice ToggleEvent when opening #342

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

rugoncalves
Copy link
Contributor

When the context menu event is opening.

This PR is for fixing the behavior in which the ContextMenu was raising the event of Toggle twice, when the ContextMenu was being open.

What was happening

  • The context menu was raising twice the toggle event when it was opening

What was done

  • Protected the place where the event was being inadvertently raised
  • The event in this place, will now only be raised when the ContextMenu is closing

Test Steps

  1. Right click on any column - context menu opens, and the message of it opening should finish with (1) in the end
  2. Repeat the operation to another column - the message should end with (2)
  3. Repeat 2. - the message should end with (3)

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

When the context menu event is opening.
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Jun 12, 2023
@rugoncalves rugoncalves changed the title Avoid raising event ContextMenu: avoid raising twice ToggleEvent when opening Jun 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rugoncalves rugoncalves changed the title ContextMenu: avoid raising twice ToggleEvent when opening ROU-4386: ContextMenu - avoid raising twice ToggleEvent when opening Jun 14, 2023
@rugoncalves rugoncalves merged commit 3803eec into dev Jun 14, 2023
@rugoncalves rugoncalves deleted the Fix-ContextMenu-Open-Event branch June 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants