Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToolTip.ts #336

Merged
merged 1 commit into from
May 22, 2023
Merged

Update ToolTip.ts #336

merged 1 commit into from
May 22, 2023

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented May 22, 2023

This PR is for adding validation to check if we do have data available, for instance, while using filters that make the Grid without results.

What was happening

  • When applying a filter that showed no results, while hovering the Grid we got errors thrown in the Developer's Tools console.

What was done

  • Added validation to check if we do have data available, for instance, while using filters that make the Grid without results.

Test Steps

Test Case 1:

  1. Go to OutSystemsDataGridSample_ROU4335/Overview
  2. Mouse Hover the Grid cells, including some with text truncated
  3. Check that the tooltip is displayed and no errors are thrown in the Dev Tools
  4. Mouse Hover the Grid Headers
  5. Check that the tooltip is displayed and no errors are thrown in the Dev Tools

Test Case 2 - Filtered List:

  1. Go to OutSystemsDataGridSample_ROU4335/Overview
  2. Filter the user name column by condition, being condition Equal to “ZZZZ“
  3. Check that the Grid is empty
  4. Mouse Hover the Grid cells, including some with text truncated
  5. Check that the tooltip is displayed and no errors are thrown in the Dev Tools
  6. Mouse Hover the Grid Headers
  7. Check that the tooltip is displayed and no errors are thrown in the Dev Tools

Screenshots

  • Issue:

IssueGridOnHoverHeader

  • After the fix:

IssueGridOnHoverHeaderFixed

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

Add validation to check if we do have data available, for instance while using filters that make the Grid without results.
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label May 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's just have a full regression on this one! :)

@gnbm gnbm merged commit af1c126 into dev May 22, 2023
@gnbm gnbm deleted the ROU-4335 branch May 22, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants