Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-1240 H&F Plugin - Implement Notification Frequency (waiting period) on Android #49

Merged

Conversation

alexgerardojacinto
Copy link
Collaborator

Description

  • This PR adds the implementation of the NotificationFrequency, also known as waiting period, on Android.

  • For NotificationFrequency equal to SECOND or MINUTE, we always wait for the next full SECOND / MINUTE to pass before sending another notification. For the rest of them, like HOUR and DAY, we only wait for the beginning of the next time unit. For example, if we send a notification at 4:55PM and at 5:00PM we have a new notification to be sent, we will send it, because we are in a new hour. On the other hand, if the frequency is MINUTE and we send a notification at 4:55PM and 30 seconds, we will wait until 4:56PM and 30 seconds to send a new notification.

  • This PR also includes the work done by @nflsilva regarding the Migration of the Room database, since we added some new values to the BackgroundJob table.

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-1240

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Tested locally on Android 11. Tested all possible NotificationFrequency values. Also built with MABS 8 and MABS 7.2.

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto alexgerardojacinto merged commit ec4adee into development Dec 10, 2021
@alexgerardojacinto alexgerardojacinto deleted the feat/RMET-1240/android-add-waiting-period branch December 20, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants