Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3511 ::: Android ::: Migrate Room Database to v2 #106

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

OS-ricardomoreirasilva
Copy link
Contributor

Description

This fixes an issue introduced in #102:

  • Add parenthesis to errorCallback to execute the call.
  • Update aar to use the latest version.

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

To test this, a new version of the Sample App was installed on top of a previous, to validate that the migration was successful.

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as ready for review July 18, 2024 08:56
@OS-ricardomoreirasilva OS-ricardomoreirasilva requested a review from a team as a code owner July 18, 2024 08:56
@OS-ricardomoreirasilva OS-ricardomoreirasilva requested review from ItsChaceD, IT-MikeS, alexgerardojacinto and OS-martacarlos and removed request for a team July 18, 2024 08:56
@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as draft July 18, 2024 09:48
@OS-ricardomoreirasilva OS-ricardomoreirasilva force-pushed the fix/silent-notifications-issue branch 11 times, most recently from ed2e7b4 to 0e4feda Compare July 19, 2024 08:45
@OS-ricardomoreirasilva OS-ricardomoreirasilva changed the title RMET-3511 ::: Android ::: Increment Database Version RMET-3511 ::: Android ::: Migrate Room Database to v2 Jul 19, 2024
@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as ready for review July 19, 2024 09:41
@OS-ricardomoreirasilva OS-ricardomoreirasilva merged commit 9276d82 into development Jul 22, 2024
6 checks passed
@OS-ricardomoreirasilva OS-ricardomoreirasilva deleted the fix/silent-notifications-issue branch July 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants