Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RDGRS-662): build image #20

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Conversation

OS-henriquesantos
Copy link

No description provided.

@OS-henriquesantos
Copy link
Author

Tested locally with goreleaser in snapshot mode:

$ goreleaser --clean --snapshot
  • skipping announce, publish and validate...
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=7ff5ffd47fc1bc7abc8ae8fd4521ba048de63918 branch=RDGRS-662-build-image current_tag=v1.9.1+os.2 previous_tag=v1.9.1+os.1 dirty=false
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=1.9.2-next
(...)
  • archives
    • creating                                       archive=dist/chisel_1.9.2-next_linux_386.tar.gz
    • creating                                       archive=dist/chisel_1.9.2-next_linux_arm64.tar.gz
    • creating                                       archive=dist/chisel_1.9.2-next_linux_amd64.tar.gz
  • calculating checksums
  • docker images
    • building docker image                          image=ghcr.io/outsystems/chisel:1.9.2-next
  • writing artifacts metadata
  • release succeeded after 3s
  • thanks for using goreleaser!

$ docker image list | grep chisel
ghcr.io/outsystems/chisel         1.9.2-next      774c208acd18   26 seconds ago   16.7MB
ghcr.io/outsystems/chisel         latest          774c208acd18   26 seconds ago   16.7MB
jpillora/chisel                   latest          dbc5464298ee   7 days ago       13.4MB
jpillora/chisel                   1.9.1           1ab9d352188d   11 months ago    12.9MB

Note that, despite the change in the base container image, the image size is not that different from the upstream one.
Also the previous Dockerfile had a copy for the certficates, but it does exist in the new alpine image:

docker run -it alpine /bin/sh -c "ls -la /etc/ssl/certs"
total 224
drwxr-xr-x    2 root     root          4096 Jul 22 14:34 .
drwxr-xr-x    4 root     root          4096 Jul 22 14:34 ..
-rw-r--r--    1 root     root        220093 Jul  9 09:59 ca-certificates.crt

This new image creation process was used for the testing mentioned in #19

@OS-henriquesantos OS-henriquesantos marked this pull request as ready for review August 12, 2024 10:19
@OS-henriquesantos OS-henriquesantos merged commit 22e6564 into master Aug 12, 2024
7 checks passed
@OS-henriquesantos OS-henriquesantos deleted the RDGRS-662-build-image branch August 12, 2024 11:23
OS-henriquesantos added a commit that referenced this pull request Aug 12, 2024
* feat(RDGRS-662): build image

* feat(RDGRS-662): restore test CI and dependabot

* feat(RDGRS-662): test CI only on linux

* feat(RDGRS-662): add version to goreleaser
OS-henriquesantos added a commit that referenced this pull request Aug 12, 2024
OS-henriquesantos added a commit that referenced this pull request Aug 13, 2024
* fix(RDGRS-662): server side keep alive
From chisel#442 . Not tested

* feat(RDGRS-662): build image (#20) (#21)

* feat(RDGRS-662): build image

* feat(RDGRS-662): restore test CI and dependabot

* feat(RDGRS-662): test CI only on linux

* feat(RDGRS-662): add version to goreleaser

* Revert "feat(RDGRS-662): build image (#20) (#21)"

This reverts commit a0feabe.

* feat(RDGRS-662): add explicit timer stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants