Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid getting a file output flatlist #98

Open
matprov opened this issue Mar 3, 2022 · 3 comments
Open

Avoid getting a file output flatlist #98

matprov opened this issue Mar 3, 2022 · 3 comments

Comments

@matprov
Copy link
Collaborator

matprov commented Mar 3, 2022

Currently every notebook gets outputted to the buildout directory, regardless of the initial folder structure in which they were located. For example, notebooks from /docs/source/notebook-components/ and /docs/source/notebooks/ are sent to the same output directory, which might cause confusion.

The solution would be to keep the initial folder structure. We would then have buildout/notebook-components and buildout/notebooks.

@tlvu
Copy link
Contributor

tlvu commented Mar 8, 2022

Another cheap way to achieve this is to have the output file right next to the original file. We already archive the original files so it falls under the same existing archiving rules and if the original files are under different folder structures, it will be preserved as well.

That said, the flat structure was for an easy access on Jenkins when browsing the archived output. Nested structure requires many clicks to go back and forth between the different folders.

I'd suggest this output structure be a toggle so the existing behavior is preserved and the new behavior can be activated when desired.

@matprov
Copy link
Collaborator Author

matprov commented Mar 9, 2022

I would say that simply preserving the input structure for the notebook outputs would be the best way to avoid name clash. Having a toggle for this type of thing is cumbersome for no reason.

@tlvu
Copy link
Contributor

tlvu commented Mar 10, 2022

I would say that simply preserving the input structure for the notebook outputs would be the best way to avoid name clash. Having a toggle for this type of thing is cumbersome for no reason.

Yeah I think you might be right. The nested directory structure is slow to navigate but I don't have to dig inside it too often yet. Let's avoid premature optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants