Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct extension for original artwork #254

Open
DarkVoyage opened this issue Apr 18, 2024 · 4 comments
Open

Set correct extension for original artwork #254

DarkVoyage opened this issue Apr 18, 2024 · 4 comments

Comments

@DarkVoyage
Copy link

DarkVoyage commented Apr 18, 2024

Set extension to what is actually acquired: JPG, PNG, GIF (very rare). Currently everything is named as JPG, which leads to either errors on opening (though XnView doesn't care for extension, reads header) or need to rename everything by hand, but first search for wrong extensions some way. Half of covers are PNG.

@Otiel
Copy link
Owner

Otiel commented Apr 25, 2024

Have you tried unchecking those options?

image

which leads to either errors on opening

This shouldn't happen. When those options are checked, a conversion is performed on the artwork, not simply a rename of the extension. Do you have a reproducible case that I could test?

@DarkVoyage
Copy link
Author

image

Sure, try downloading this: https://lisabelladonna.bandcamp.com/album/electronic-voyages-3
You will get PNG with .jpg extension. It is hardcoded.
In options better write .ext or .extension than .jpg.

@Otiel
Copy link
Owner

Otiel commented Apr 25, 2024

Seems like a big, thanks for reporting this. 👍

@DarkVoyage
Copy link
Author

DarkVoyage commented Apr 25, 2024

It is in JsonAlbum.cs

internal class JsonAlbum
{
private readonly string _urlEnd = "_0.jpg";

But you can't simply change it to anything. You should read first bytes of downloaded file to get the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants