Making Offer on Android fails

[sparrowDom]

When @kayyoo23 is trying to make an offer from her Android she consistently gets stuck on this screen.

These are the errors reported by Sentry from her device: error 1 error 2 error 3 error 4

[mikeshultz]

I don't understand why it's requesting a transaction receipt when no transaction has even been sent.

Account: https://etherscan.io/address/0x0bB2C6478677aCbAd673e1D55FD26B0C06Ae2e18
Proxy: https://etherscan.io/address/0x2cad506fa67291ce479eca86d6ec5ebfa5ff7336

[mikeshultz]

This issue encompasses #3275, #3410

I think Invalid params is perhaps at the core of this one.

[franckc]

I watched @kayyoo23 try to make an offer on a different listing. This time she got stuck on the confirmation page. The blue button for confirming had a spinner and never became clickable.

[mikeshultz]

Actually, I'm gonna say it's the messaging bug (shipping address) broken out in #3410.

[tomlinton]

This would happen if this resolved but failed to have sent this transaction. If it errored the app should crash and we should see something reported in Sentry for origin-mobile. It seems like it is resolving but never sending the transaction correctly. I wonder if it is something with Alchemy. But that doesn't make sense if it is just limited to that one device.

[tomlinton]

I don't think this is Android (or mobile) specific. I think its more likely an issue with Alchemy.

[mikeshultz]

@tomlinton could this be caused by it getting garbage for transaction/msgData.data?

[tomlinton]

I think that is unlikely as all of the data in that screenshot above is parsed from the transaction data in msgData.data.

[mikeshultz]

ok, so, had a look at the ethers.js docs:

Sends the transaction (see Transaction Requests) to the network and returns a Promise that resolves to a Transaction Response. Any properties that are not provided will be populated from the network.

The transaction response object appears to be a regular old transaction object and it doesn't appear to block for mining or anything.

I have no idea what the behavior would be with some of the Alchemy behavior. For instance, what does Ethers.js do upon a 429 rate limiting behavior? This was a big part of the reasoning for building our own web3.js provider. And I'm not really sure how we should approach this either, since the mobile app doesn't use web3.js in this case.

Here's some interesting relevant discussion. Looks like it might be relatively easy to add this functionality.

Though I'm still wondering if we aren't off-base here. At least one of the relevant errors in Sentry are specifically coming from within web3.

[tomlinton]

Interesting, I'd hope ethers would throw on any non-success codes. I was thinking Alchemy might be returning something that looks like a success code but actually isn't (i.e. a 200 response on something that is an error with an error message in the response that needs to be parsed).

[micahalcorn]

Closing until we get another report 🤞