Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Update contract events to use emit #65

Closed
wanderingstan opened this issue Mar 29, 2018 · 4 comments
Closed

Update contract events to use emit #65

wanderingstan opened this issue Mar 29, 2018 · 4 comments
Labels
enhancement New feature or request smart contracts solidity

Comments

@wanderingstan
Copy link
Contributor

Solidity has been updated and now events are required to be prefaced with emit keyword.

See: http://solidity.readthedocs.io/en/v0.4.21/contracts.html#events

See: ethereum/solidity#2877
@wanderingstan
Copy link
Contributor Author

@nick points out that truffle's version of solc may not support this yet...

@wanderingstan
Copy link
Contributor Author

@crazybuster points out that it is supported in truffle's develop branch.

We'll wait until new release of truffle comes out: https://github.com/trufflesuite/truffle/releases

@wanderingstan wanderingstan added enhancement New feature or request smart contracts labels Mar 29, 2018
@wanderingstan
Copy link
Contributor Author

Woa, new version of truffle was just released with support for emit
https://github.com/trufflesuite/truffle/releases/tag/v4.1.5

Game on.

@wanderingstan
Copy link
Contributor Author

This is subsumed by #96 , which includes other solidity fixes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request smart contracts solidity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wanderingstan @matthewliu