diff --git a/.github/DEVELOP.md b/.github/DEVELOP.md index 6dd1e2f0b..7a0791ed5 100644 --- a/.github/DEVELOP.md +++ b/.github/DEVELOP.md @@ -277,7 +277,7 @@ We can add metafields picked from [this good guideline](https://git.kernel.org/p This is not mandatory (yet) but a good practice and quite interesting to know who reviewed and validated what. You must mention *co-authors* (*Co-authored-by*). You should add who are code reviewers (*Reviewed-by*), evolutions testers (*Tested-by*) and if needed ackers (*Acked-by*). -For example, for issue n°123 and its pull request n°456, tested by Anton, Iman, Maxime, Stephen, Pierre-Yves and Benoit, reviewed by Ludovic, authored by Tayeb and Pierre-Yves, and acked by Julien: +For example, for issue n°123 and its pull request n°456, tested by Anton, Iman, Maxime, Pierre-Yves and Benoit, reviewed by Ludovic, authored by Tayeb and Pierre-Yves, and acked by Stephen: ```text refactor: update some things colors and design of the demo app (#123) (#4562) @@ -287,10 +287,9 @@ Tested-by: Iman Assabah Tested-by: Anton Astafev Tested-by: Benoit Suzanne Tested-by: Maxime Tonnerre -Tested-by: Stephen McCarthy Tested-by: Pierre-Yves Ayoul Reviewed-by: Ludovic Pinel -Acked-by: Julien Déramond +Acked-by: Stephen McCarthy Co-authored-by: Tayeb Sedraia Co-authored-by: Pierre-Yves Lapersonne Signed-off-by: Tayeb Sedraia diff --git a/DesignToolbox/fastlane/Fastfile b/DesignToolbox/fastlane/Fastfile index c84a6301b..94a3267e8 100644 --- a/DesignToolbox/fastlane/Fastfile +++ b/DesignToolbox/fastlane/Fastfile @@ -34,7 +34,7 @@ APPLE_KEY_CONTENT = ENV["OUDS_APPLE_KEY_CONTENT"] # Bundle identifier of the app DEVELOPER_APP_IDENTIFIER = ENV["OUDS_DEVELOPER_BUNDLE_IDENTIFIER"] -# Upload To Store +# URL for internal portal to upload to App Store UPLOAD_STORE_URL = ENV["OUDS_UPLOAD_STORE_URL"] # Notifications and hooks diff --git a/docs_release/README.md b/docs_release/README.md index 717191929..0180a02d4 100644 --- a/docs_release/README.md +++ b/docs_release/README.md @@ -81,7 +81,7 @@ Fixed: - [Library] Fix some typos in documentation ([#89](#89)) // Add in co authors anyone working on the commits being merged, add the ones who contributed (copy-paste if too lazy, use the ones you need) -Co-authored-by: Julien Déramond +Co-authored-by: Benoit Suzanne Co-authored-by: Pierre-Yves Lapersonne Co-authored-by: Ludovic Pinel Co-authored-by: Tayeb Sedraia @@ -103,17 +103,20 @@ You can also [look inside this commit](https://github.com/Orange-OpenSource/ouds - Or use _Fastlane_ command: ```shell # Variables for application signing - export OUDS_DEVELOPER_APP_IDENTIFIER= + export OUDS_DEVELOPER_BUNDLE_IDENTIFIER= export OUDS_FASTLANE_APPLE_ID= export OUDS_DEVELOPER_PORTAL_TEAM_ID= - # Variables to Upload to TestFlight + # Variables for upload to TestFlight export OUDS_APPLE_KEY_ID = export OUDS_APPLE_ISSUER_ID = export OUDS_APPLE_KEY_CONTENT = + # Variables for internal portal upload (for in the end App Store) + export OUDS_UPLOAD_STORE_URL = + bundle exec fastlane prod upload:true - # set "upload" to true if you want to upload app to TestFlight, false otherwise. + # set "upload" to true if you want to upload app to internal portal, false otherwise. ``` ### Publish release to GitHub