Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Insecure flag for CassandraBackup #310

Open
an-tex opened this issue Mar 23, 2021 · 6 comments
Open

Insecure flag for CassandraBackup #310

an-tex opened this issue Mar 23, 2021 · 6 comments
Labels
good first issue Good for newcomers

Comments

@an-tex
Copy link

an-tex commented Mar 23, 2021

Feature Request

Is your feature request related to a problem? Please describe.

When using a self-deployed S3 solution like minio the use case arises for using insecure HTTP connections. This currently can't be configured.

Describe the solution you'd like to see
https://github.com/instaclustr/icarus allows setting an "insecure: true" flag. This flag could be included in the CassandraBackup CRD which in turn passes it's value to icarus

@cscetbon cscetbon added the good first issue Good for newcomers label Mar 24, 2021
@cscetbon
Copy link
Contributor

@an-tex what about providing a PR ? The change should be minimal, at the CRD, in the controller and a unit test to confirm it’s taken into account. That should be a parameter on both the backup and restore objects.

@an-tex
Copy link
Author

an-tex commented Mar 25, 2021

Thanks for the directions @cscetbon . I've never done anything with go but I'll give it a shot :)

@an-tex
Copy link
Author

an-tex commented Mar 25, 2021

Waiting for instaclustr/instaclustr-icarus-go-client#3

@cscetbon
Copy link
Contributor

@an-tex It seems that PR has been merged. It might be a good time to get back to it ;)

@an-tex
Copy link
Author

an-tex commented Apr 28, 2021

Yes but there's no package available, please have a look here instaclustr/instaclustr-icarus-go-client#4 (comment) @cscetbon

@cscetbon
Copy link
Contributor

@an-tex I'm not sure why you need a package ? CassKop depends on the GitHub repo directly not on any released package, see https://github.com/Orange-OpenSource/casskop/blob/master/go.mod#L17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants