From 8c829c60c437713a3f844ea63f577171e02e3132 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Thu, 30 Mar 2023 18:12:59 +0200 Subject: [PATCH 1/7] Fix comments --- scss/_popover.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index e37e1caaac..8029a342e6 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -62,7 +62,7 @@ .bs-popover-top { > .popover-arrow { - bottom: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); /* stylelint-disable-line function-disallowed-list */ + bottom: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); // stylelint-disable-line function-disallowed-list &::before, &::after { @@ -84,7 +84,7 @@ /* rtl:begin:ignore */ .bs-popover-end { > .popover-arrow { - left: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); /* stylelint-disable-line function-disallowed-list */ + left: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); // stylelint-disable-line function-disallowed-list width: var(--#{$prefix}popover-arrow-height); height: var(--#{$prefix}popover-arrow-width); @@ -109,7 +109,7 @@ .bs-popover-bottom { > .popover-arrow { - top: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); /* stylelint-disable-line function-disallowed-list */ + top: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); // stylelint-disable-line function-disallowed-list &::before, &::after { @@ -143,7 +143,7 @@ /* rtl:begin:ignore */ .bs-popover-start { > .popover-arrow { - right: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); /* stylelint-disable-line function-disallowed-list */ + right: calc((-1 * var(--#{$prefix}popover-arrow-height)) - var(--#{$prefix}popover-border-width)); // stylelint-disable-line function-disallowed-list width: var(--#{$prefix}popover-arrow-height); height: var(--#{$prefix}popover-arrow-width); From 0c9abd6aa3ce1036a76735683f9d70dfd1ce3c00 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Thu, 30 Mar 2023 18:13:46 +0200 Subject: [PATCH 2/7] Fix border width --- scss/_popover.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index 8029a342e6..ede40699a6 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -75,7 +75,7 @@ } &::after { - bottom: var(--#{$prefix}popover-border-width); + bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -99,7 +99,7 @@ } &::after { - left: var(--#{$prefix}popover-border-width); + left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } @@ -122,7 +122,7 @@ } &::after { - top: var(--#{$prefix}popover-border-width); + top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-bottom-color: var(--#{$prefix}popover-bg); } } @@ -158,7 +158,7 @@ } &::after { - right: var(--#{$prefix}popover-border-width); + right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-left-color: var(--#{$prefix}popover-bg); } } From 3943e660ad4a68b63c1552e96be0650ee0341e64 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Fri, 31 Mar 2023 09:02:20 +0200 Subject: [PATCH 3/7] Fix border width --- scss/_popover.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index ede40699a6..466a39aa7c 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -75,7 +75,7 @@ } &::after { - bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -99,7 +99,7 @@ } &::after { - left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } @@ -122,7 +122,7 @@ } &::after { - top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-bottom-color: var(--#{$prefix}popover-bg); } } @@ -158,7 +158,7 @@ } &::after { - right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) / 2)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-left-color: var(--#{$prefix}popover-bg); } } From 6889c21ed6fe9f2555339f2c2cf8e2cc8d7af120 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Fri, 31 Mar 2023 15:54:07 +0200 Subject: [PATCH 4/7] Fix stylelint multiline comments --- scss/_popover.scss | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index 466a39aa7c..ce4efc8404 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -75,7 +75,8 @@ } &::after { - bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + // stylelint-disable-next-line function-disallowed-list + bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -99,7 +100,8 @@ } &::after { - left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + // stylelint-disable-next-line function-disallowed-list + left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } @@ -122,7 +124,8 @@ } &::after { - top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + // stylelint-disable-next-line function-disallowed-list + top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-bottom-color: var(--#{$prefix}popover-bg); } } @@ -158,7 +161,8 @@ } &::after { - right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); /* stylelint-disable-line function-disallowed-list */ // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + // stylelint-disable-next-line function-disallowed-list + right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-left-color: var(--#{$prefix}popover-bg); } } From 65bdf3858d7a05057f00c14eeeef53ecb5483ebe Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Wed, 12 Apr 2023 15:28:40 +0200 Subject: [PATCH 5/7] Fix --- scss/_popover.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index ce4efc8404..8803860197 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -76,7 +76,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - bottom: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + bottom: calc(var(--#{$prefix}popover-border-width) + var(--#{$prefix}popover-border-width) * .5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -101,7 +101,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - left: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + left: calc(var(--#{$prefix}popover-border-width) + var(--#{$prefix}popover-border-width) * .5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } From e95689595a65efea81bced057347e684ec62b004 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Wed, 12 Apr 2023 15:48:08 +0200 Subject: [PATCH 6/7] Improve fix --- scss/_popover.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index 8803860197..0543000ab6 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -76,7 +76,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - bottom: calc(var(--#{$prefix}popover-border-width) + var(--#{$prefix}popover-border-width) * .5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + bottom: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -101,7 +101,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - left: calc(var(--#{$prefix}popover-border-width) + var(--#{$prefix}popover-border-width) * .5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + left: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } @@ -125,7 +125,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - top: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + top: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-bottom-color: var(--#{$prefix}popover-bg); } } @@ -162,7 +162,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - right: calc(var(--#{$prefix}popover-border-width) + calc(var(--#{$prefix}popover-border-width) * .5)); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + right: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-left-color: var(--#{$prefix}popover-bg); } } From 23cfc628f26a56037b323a2e1a2a0951f7b5fe50 Mon Sep 17 00:00:00 2001 From: MewenLeHo Date: Wed, 12 Apr 2023 15:50:30 +0200 Subject: [PATCH 7/7] Improve fix --- scss/_popover.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_popover.scss b/scss/_popover.scss index 0543000ab6..0bbaf013fa 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -76,7 +76,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - bottom: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + bottom: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-top-color: var(--#{$prefix}popover-bg); } } @@ -101,7 +101,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - left: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + left: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-right-color: var(--#{$prefix}popover-bg); } } @@ -125,7 +125,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - top: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + top: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-bottom-color: var(--#{$prefix}popover-bg); } } @@ -162,7 +162,7 @@ &::after { // stylelint-disable-next-line function-disallowed-list - right: calc(var(--#{$prefix}popover-border-width) * 1.5 ); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` + right: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)` border-left-color: var(--#{$prefix}popover-bg); } }