Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back form-control-sm #1100

Closed
2 tasks done
MewenLeHo opened this issue Feb 15, 2022 · 2 comments
Closed
2 tasks done

Bring back form-control-sm #1100

MewenLeHo opened this issue Feb 15, 2022 · 2 comments
Assignees
Labels

Comments

@MewenLeHo
Copy link
Contributor

MewenLeHo commented Feb 15, 2022

Prerequisites

Proposal

According to Cyriaque : "In some exceptional cases we provide components with a lower dont 14 px font size such a Small button or Small quantity selector" :

Therefore we need to put back small inputs (i.e. form controls with CSS class .form-control-sm) into Boosted.

Motivation and context

It will be helpfull to simply use CSS class '.form-control-sm intead of doing weird things like what we have done for the quantity selector (i.e. '$input-padding-y-sm: divide($input-padding-y, 2) !default; // Boosted mod').

@MewenLeHo MewenLeHo self-assigned this Feb 15, 2022
@MewenLeHo MewenLeHo mentioned this issue Feb 15, 2022
13 tasks
@MewenLeHo MewenLeHo changed the title Put back form-control-sm Bring back form-control-sm Feb 17, 2022
@julien-deramond julien-deramond changed the title Bring back form-control-sm Bring back form-control-sm Feb 21, 2022
@louismaximepiton
Copy link
Member

Since the .form-control-sm is back in Boosted, should we try to take a look at this one again ?

@julien-deramond
Copy link
Member

Closing it since .form-control-sm is back to Boosted via #1230.
Create a new one to see if using .form-control-sm in our Boosted specific small form controls can be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants