Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelorama crashes when import incorrectly formatted .gpl (GIMP Color Palette) file #363

Closed
LiquidFun opened this issue Oct 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@LiquidFun
Copy link

LiquidFun commented Oct 23, 2020

Pixelorama version: v0.8.1-stable, from AUR pixelorama-bin package

OS/device including version: Arch Linux

Issue description & steps to reproduce:

I created my own palettes using a script and accidentally created an incorrectly formatted .gpl file (note the missing colon after "Columns"):

GIMP Palette
Name: Generated Palette
Columns 0
#
244 252 214

Readding the colon works as expected, i.e. this is ok:

GIMP Palette
Name: Generated Palette
Columns: 0
#
244 252 214

Importing the former into Pixelorama causes it to straight up crash.

Only output I get is when running it via terminal, then I see a segmentation fault:

$ pixelorama
Godot Engine v3.2.3.stable.official - https://godotengine.org
OpenGL ES 2.0 Renderer: GeForce GTX 750 Ti/PCIe/SSE2
OpenGL ES 2.0 Batching: ON
 
Detected system where we should use XDG basedir standard (currently Linux or BSD)
[1]    111675 segmentation fault (core dumped)  pixelorama

I doubt this happens all that often, but I guess it still shouldn't crash?

@LiquidFun LiquidFun added the bug Something isn't working label Oct 23, 2020
@OverloadedOrama
Copy link
Member

Thanks for reporting, I just pushed a fix for this issue. Feel free to try it by downloading the dev builds from the Actions page, once they're generated.

@LiquidFun
Copy link
Author

Thanks for the quick response! Will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants