Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Pick Color with Alt and mouse button. #125

Closed
Tracked by #365
kakoeimon opened this issue Jan 14, 2020 · 7 comments
Closed
Tracked by #365

Request: Pick Color with Alt and mouse button. #125

kakoeimon opened this issue Jan 14, 2020 · 7 comments
Labels
change Proposes changes on how something works discussion This needs more ideas, feedback, discussion in general.

Comments

@kakoeimon
Copy link

Right now the color picker exist only as a separated tool, the request is to be and a tool that leaves inside the Draw tools, Pencil and Bucket and pick colors by holding down the Alt key and pressing the left mouse button for the left color or the right mouse button for the right color.
This will improve the workflow tremendously and possible this is the reason that almost all the drawing apps have something similar.

@OverloadedOrama OverloadedOrama added the discussion This needs more ideas, feedback, discussion in general. label Jan 15, 2020
@novhack
Copy link
Contributor

novhack commented Mar 5, 2020

I would strongly advice against using Alt+mouse combination anywhere because that is what most Linux DEs use to manipulate windows.

@Calinou
Copy link
Contributor

Calinou commented Mar 5, 2020

@novhack Unfortunately, we may not have a choice if other mouse combinations are already taken. Maybe using Alt + Ctrl + mouse or Alt + Shift + mouse could work out of the box on Linux, but it's also more tedious.

Alternatively, we can allow both Alt + mouse and Meta + mouse to do the same thing (except on macOS).

@novhack
Copy link
Contributor

novhack commented Mar 6, 2020

Couldn't Ctrl + mouse be used? I haven't found any other combination where Ctrl + mouse is used other than when combined with Shift to draw lines at certain angles. Or am I missing a hidden feature?

@OverloadedOrama OverloadedOrama added the change Proposes changes on how something works label Apr 16, 2020
@Ryhon0
Copy link

Ryhon0 commented Apr 25, 2020

I added this feature to my fork. When you hold Ctrl + mouse it sets the left or right color depending on what button you pressed to whatever is under your cursor. I just copied the color picker code and checked if user is holding Ctrl. It's not the best code, but it works

@Wishdream
Copy link
Contributor

Why not just allow people to reassign Shift, Alt and Ctrl on tool use?
I'm on Linux, and I basically moved my Alt to Meta for moving windows.

Say like Shift is Alt. Tool Mode.

Similar to Krita's Canvas Input Settings:
image

@vlandemart
Copy link

I wrote my ideas in #508

@OverloadedOrama
Copy link
Member

The ability to pick colorswhile holding Alt while a drawing tool is selected (Pencil, Eraser, Shading, Bucket, Line, Rectangle & Ellipse) is now implemented and will be included in v0.9.1. I will document it when v0.9.1 is out, but maybe having some sort of visual cue when Alt is being held could be useful to avoid confusion.

For now there is no way to change the keyboard button shortcut but it is a planned feature (tracked in #309). Fortunately, there is no conflict with other shortcuts. While Alt is already being used in the shape tools to displace the shape's position, it only works after the mouse click, while picking colors gets activated if Alt is pressed before the mouse click. As for the Linux issue, I'm not sure if we can do something about it until we implement better shortcut customization as mentioned above. In my end (Pop!_OS with KDE Plasma), I didn't notice any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Proposes changes on how something works discussion This needs more ideas, feedback, discussion in general.
Projects
None yet
Development

No branches or pull requests

7 participants