Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ERC721 interfaces abstract again #990

Closed
frangio opened this issue Jun 9, 2018 · 1 comment · Fixed by #993
Closed

Make ERC721 interfaces abstract again #990

frangio opened this issue Jun 9, 2018 · 1 comment · Fixed by #993

Comments

@frangio
Copy link
Contributor

frangio commented Jun 9, 2018

The ERC721 interfaces should probably be deriving the interface ERC165 instead of the implementation SupportsInterfaceWithLookup.

https://github.com/OpenZeppelin/openzeppelin-solidity/blob/b0292cf628d9f8d65615bc07dd8af4844eb5a6d6/contracts/token/ERC721/ERC721Basic.sol#L10

The logic for registering the proper interfaces should then be moved to the implementations.
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/b0292cf628d9f8d65615bc07dd8af4844eb5a6d6/contracts/token/ERC721/ERC721Basic.sol#L47-L53
@shrugs
Copy link
Contributor

shrugs commented Jun 10, 2018

Ah, true, good point. will update today.

@shrugs shrugs mentioned this issue Jun 10, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/erc721 shrugs/openzeppelin-solidity
2 participants
@frangio @shrugs