Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback From Open Zeppelin About ERC-173 Contract Ownership Standard #987

Closed
mudgen opened this issue Jun 8, 2018 · 3 comments
Closed

Comments

@mudgen
Copy link

mudgen commented Jun 8, 2018

A new proposal/draft for the contract interface for owning and transferring ownership of contracts was recently written and merged with the ethereum eip project. The draft is here: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-173.md

What is Open Zepplin's response/feedback about this?

Also, can Open Zepplin help get the word out about contract ownership becoming standardized? Get the word out about this EIP draft so it can get the feedback it needs for standardization.

@frangio
Copy link
Contributor

frangio commented Jun 8, 2018

Hi there, @mudgen.

An important piece of feedback is that the semantics of the functions and events don't seem to be specified at all.

@mudgen
Copy link
Author

mudgen commented Jun 8, 2018

@frangio thank you for your comment. I noticed that the "@notice" for the transferOwnership() function was wrong so I fixed that and will be in the next pull request.

The notice for the transferOwnership() function now says, "Set the address of the new owner of the contract". The notice for the owner() function says, "Get the address of the owner " Are more semantics needed? If so can you give a better idea of the semantics that should be included?

I added this note: "The OwnershipTransferred event does not have to be emitted when a contract is created."

Implementations of functions owner() and transferOwnership() are unspecified because they can be implemented how people want to implement them. But the standard does link to Open Zepplin's implementation of the standard as an example.

@frangio
Copy link
Contributor

frangio commented Jun 9, 2018

Closing as discussion should be happening in ethereum/EIPs#173.

@frangio frangio closed this as completed Jun 9, 2018
@axic axic mentioned this issue Sep 21, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants