Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings.toString doesn't compile with integer literals #4298

Closed
frangio opened this issue Jun 2, 2023 · 2 comments · Fixed by #4330
Closed

Strings.toString doesn't compile with integer literals #4298

frangio opened this issue Jun 2, 2023 · 2 comments · Fixed by #4330
Labels
breaking change Changes that break backwards compatibility of the public API. good first issue Low hanging fruit for new contributors to get involved!

Comments

@frangio
Copy link
Contributor

frangio commented Jun 2, 2023 •
edited
Loading

As seen in the forum, Strings.toString(1) does not compile in 4.9.0 because 1 could be a signed or unsigned integer and toString is available for signed integers since #3773.

We should rename the function to toStringSigned so that the basic toString function can be used with integer literals.
@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Jun 2, 2023
@frangio
Copy link
Contributor Author

frangio commented Jun 8, 2023

@Amxx @ernestognw Would you agree with renaming this? If so we can mark this as good first issue.

@Amxx Amxx added the good first issue Low hanging fruit for new contributors to get involved! label Jun 9, 2023
@balajipachai balajipachai mentioned this issue Jun 9, 2023
Merged
@himansh295
Copy link

Hi @frangio is this issue is still open.I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API. good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename toString to toStringSigned balajipachai/openzeppelin-solidity
3 participants
@frangio @Amxx @himansh295