Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ifAdmin getters from TransparentUpgradeableProxy #3599

Closed
frangio opened this issue Aug 4, 2022 · 1 comment
Closed

Remove ifAdmin getters from TransparentUpgradeableProxy #3599

frangio opened this issue Aug 4, 2022 · 1 comment
Labels
breaking change Changes that break backwards compatibility of the public API.
Milestone
5.0

Comments

@frangio
Copy link
Contributor

frangio commented Aug 4, 2022

TransparentUpgradeableProxy has getters admin() and implementation() but these functions are guarded by ifAdmin, as a result calling the function by anyone except the admin will not return the values. This is specially visible on Etherscan where admin will display as 0x:

image

This essentially makes the getters useless so we might as well remove them.
@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Aug 4, 2022
@frangio frangio added this to the 5.0 milestone Aug 4, 2022
@SecondPort SecondPort mentioned this issue Sep 16, 2022
Closed
3 tasks
@JulissaDantes JulissaDantes mentioned this issue Nov 17, 2022
Merged
3 tasks
@JulissaDantes
Copy link
Contributor

Implemented by #3820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

ifAdmin removed from TransparentUpgradeableProxy
2 participants
@frangio @JulissaDantes