Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimelockController: Use default admin role #3389

Closed
frangio opened this issue May 2, 2022 · 3 comments
Closed

TimelockController: Use default admin role #3389

frangio opened this issue May 2, 2022 · 3 comments
Labels
breaking change Changes that break backwards compatibility of the public API.
Milestone
5.0

Comments

@frangio
Copy link
Contributor

frangio commented May 2, 2022

TimelockController currently uses a custom non-zero TIMELOCK_ADMIN role that has complicated the introduction of the new CANCELLER_ROLE in 4.6 and necessitated a custom migration to set the role admin that would not have been necessary had DEFAULT_ADMIN_ROLE been used.

Moving forward we should always use the default admin role rather than custom roles.
@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label May 2, 2022
@Niceural
Copy link
Contributor

Hi! Does this issue need a pr?

@Amxx Amxx added this to the 5.0 milestone Jul 17, 2022
@frangio
Copy link
Contributor Author

frangio commented Jul 18, 2022

It's a breaking change so we're not doing it yet.

@JulissaDantes JulissaDantes mentioned this issue Nov 3, 2022
Merged
3 tasks
@frangio
Copy link
Contributor Author

frangio commented Dec 2, 2022

Fixed by #3799 for future 5.0 release.

@frangio frangio closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
3 participants
@frangio @Amxx @Niceural