Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a separate ERC721 and EIP2981 with the full and strict interface of EIP721 #3087

Closed
liron-navon opened this issue Jan 7, 2022 · 2 comments

Comments

@liron-navon
Copy link

🧐 Motivation
The current ERC721 interface from openzepplin is deviating from the standard EIP721 interface, we need to make NFTs with royalties support, so we need functions like "safeTransferFrom" to be "payable".

📝 Details
Open zepplin is missing some contract information to allow to create ERC721 that implement royalties, I'd like to suggest the implementation of the strict EIP721 as defined here: https://eips.ethereum.org/EIPS/eip-721
And the EIP2981 as defined here: https://eips.ethereum.org/EIPS/eip-2981

@Amxx
Copy link
Collaborator

Amxx commented Jan 7, 2022

duplicate of #2610

@Amxx Amxx closed this as completed Jan 7, 2022
@frangio
Copy link
Contributor

frangio commented Jan 7, 2022

Note that ERC-2981 was merged yesterday (#3012), it will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants