Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PullPayment version that checks balances #197

Closed
maraoz opened this issue Apr 20, 2017 · 1 comment
Closed

PullPayment version that checks balances #197

maraoz opened this issue Apr 20, 2017 · 1 comment
Labels
feature New contracts, functions, or helpers.

Comments

@maraoz
Copy link
Contributor

maraoz commented Apr 20, 2017

asyncSend allows more balance to be queued up for sending than the contract holds. I don't see any way to prevent this, given the inheriting contract can manage its balance as it wants. Even if we added a uint counter on the total debt and failed when it exceeds this.balance, the balance can go down by other means.
Still, it would be nice to have a version of PullPayment with balance available guards to prevent most cases of misuse.
I would do this as a subcontract of PullPayment.
@maraoz maraoz added the feature New contracts, functions, or helpers. label Apr 20, 2017
@frangio frangio removed the backlog label Jun 15, 2018
@nventuro
Copy link
Contributor

Closing since this was fixed by #1014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New contracts, functions, or helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maraoz @frangio @eternauta1337 @nventuro