Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy implementation hash can be zero #392

Closed
milancermak opened this issue Jul 11, 2022 · 1 comment · Fixed by #394
Closed

Proxy implementation hash can be zero #392

milancermak opened this issue Jul 11, 2022 · 1 comment · Fixed by #394

Comments

@milancermak
Copy link
Contributor

The _set_implementation_hash in proxy library has an expected error message "Proxy: implementation hash cannot be zero", but in fact, there's no assert ensuring that the new_implementation value is not zero. This seems like an oversight, so I'm rather opening an issue.
@andrew-fleming andrew-fleming added this to the next milestone Jul 12, 2022
@andrew-fleming
Copy link
Collaborator

Thanks, @milancermak!

@andrew-fleming andrew-fleming moved this to 📋 Backlog in Cairo team Jul 12, 2022
@andrew-fleming andrew-fleming mentioned this issue Jul 12, 2022
Merged
3 tasks
@andrew-fleming andrew-fleming moved this from 📋 Backlog to 🏗 In progress in Cairo team Jul 12, 2022
@martriay martriay moved this from 🏗 In progress to ✅ Done in Cairo team Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix proxy assertion andrew-fleming/cairo-contracts
2 participants
@milancermak @andrew-fleming