gui + multiple wakeword support + more langs + code cleanup #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JarbasAl
commented
Nov 4, 2021
•
JarbasAl
commented
- emits bus messages for mute/unmute events for all platforms (remove string check)
- support for multiple wake words PR, say correct wake word on naptime dialog
- remove the count to 5, after 5 times in the device lifetime the dialog would change and be greatly simplified irreversibly
- make all animations (mk1 + gui) event based, all those sleeps made the voice interaction feel laggy
- minor refactoring and cleanup of functions names etc
- ports qml files from Add sleep/wake face from Mark II Skill MycroftAI/skill-naptime#41
- ports missing lang resources from official skill
JarbasAl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.