-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies are duplicated + add version specs #5
Comments
I can help on this. Which file should they be in? |
In OSM, we put them in |
To be honest, I did about 10 minutes of research, another 10 minutes of trying to break it, and concluded that StackOverflow was right this time. I have no idea if that's a best practice or a kludge. |
Alternate method I started using (before I knew def get_requirements(requirements_filename: str):
requirements_file = path.join(path.abspath(path.dirname(__file__)), "requirements", requirements_filename)
with open(requirements_file, 'r', encoding='utf-8') as r:
requirements = r.readlines()
requirements = [r.strip() for r in requirements if r.strip() and not r.strip().startswith("#")]
return requirements |
dependencies are duplicated in setup.py and requirements.txt. Also, should add version specs to all deps
The text was updated successfully, but these errors were encountered: