-
-
Notifications
You must be signed in to change notification settings - Fork 6
Uncaught custom exceptions during most operations should warn rather than crash #38
Comments
that should never happen, lets be sure to log it loud and clear if it happens, we need to fix root cause |
That particular case shouldn't happen anymore, but some of these exceptions exist to break out of routines that would otherwise try to parse a bunch of |
I now see the confusion. Poorly titled, but I can't think of a better one. I mean, several existing, uncaught cases of the GitHub-related custom exceptions should warn rather than crashing. I didn't include a list because I discovered the problem in passing. It will require a deeper dive to find the wheres. |
Related to this, I think the |
Is this still valid? I thought everything in a loop got a try/except inside already.. |
the whole point of the dedicated exceptions is throwing/catching them when they make sense if its uncaught, thats the point of adding it in the first place, go fix it! imho this issue is wontfix unless i misunderstood |
You misunderstood. Either this issue is resolved, or we just haven't had enough opportunities to use |
If, for instance, we get one of the GitHub parsing exceptions during
osm sync
, the malformation of a single skill entry should not crash osm, nor prevent the rest of the sync from finishing.The text was updated successfully, but these errors were encountered: