New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"enable audio recordings" intent match #73

Closed

NeonDaniel opened this issue Apr 11, 2023 · 1 comment · Fixed by OpenVoiceOS/ovos-core#396

Labels

wontfix

Member

NeonDaniel commented Apr 11, 2023

User reported handling of "enable audio recordings" by OCP. OCP should probably look for a "play" keyword to prevent unexpected matches

2023-04-11 11:32:48.433 - skills - neon_core.skills.intent_service:handle_utterance:219 - INFO - ['enable audio recordings']

Member

JarbasAl commented Apr 11, 2023 •

edited

Loading

this is padatious disambiguation bug, out of scope for OCP, OCP already captures play XXXonly and then uses a sub parser - intents https://github.com/OpenVoiceOS/ovos-ocp-audio-plugin/blob/dev/ovos_plugin_common_play/ocp/__init__.py#L120

marked as wontfix because no examples in the .intent file are remotely similar to that example

Related OpenVoiceOS/ovos-plugin-manager#47

JarbasAl added the wontfix label

JarbasAl mentioned this issue

The OCP Sprint OpenVoiceOS/ovos-media#15

Open

NeonJarbas mentioned this issue

ocp pipeline OpenVoiceOS/ovos-core#396

Merged

NeonDaniel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment