Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Classic Mycroft skill inits are not calling self.initialize() #343

Closed
mikejgray opened this issue Aug 19, 2023 · 2 comments
Closed
Assignees
Labels
breaking breaks backwards compatibility (kinda) bug Something isn't working
Milestone

Comments

@mikejgray
Copy link

Per findings here:
OpenVoiceOS/ovos-skill-wolfie#14

In at least one case, and possibly in the wikipedia skill too, a skill with a create_skill() function and a Skill self.initialize() method is not calling the self.initialize() method.

ovos@mark1-dev:~ $ pip list | grep ovos-core
ovos-core                            0.0.8a27

Not sure how far back this goes, but this is the version on the Mark 1 where I found the issue. Running RaspOvos image for Mark 1.

@ChanceNCounter ChanceNCounter added bug-ovos breaking breaks backwards compatibility (kinda) labels Aug 19, 2023
@JarbasAl JarbasAl added bug Something isn't working and removed bug-ovos labels Aug 21, 2023
@JarbasAl
Copy link
Member

i think this has been fixed in the meantime

@JarbasAl JarbasAl added this to the 0.0.8 milestone Feb 22, 2024
@JarbasAl JarbasAl assigned mikejgray and unassigned ChanceNCounter Feb 24, 2024
@JarbasAl
Copy link
Member

JarbasAl commented Mar 2, 2024

can't replicate, closing. re-open if theres still an issue

@JarbasAl JarbasAl closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaks backwards compatibility (kinda) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants