From 38a7610b18ff01f7d2b115f8b4a7d2538acd259b Mon Sep 17 00:00:00 2001
From: Marti Martz <Martii@users.noreply.github.com>
Date: Fri, 9 Feb 2018 21:04:00 -0700
Subject: [PATCH] Resuspend http `@icon` check (#1327)

* Bogus domain causes untrapped `RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ENOTFOUND`

Applies to #1323

Auto-merge
---
 controllers/scriptStorage.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/controllers/scriptStorage.js b/controllers/scriptStorage.js
index 4883ce2d6..c0d4e041a 100644
--- a/controllers/scriptStorage.js
+++ b/controllers/scriptStorage.js
@@ -1467,10 +1467,8 @@ exports.storeScript = function (aUser, aMeta, aBuf, aUpdate, aCallback) {
           fn = /^http:/.test(icon) ? http : https;
 
           // Workaround for #1323
-          if (fn === https) {
-            aInnerCallback(null); // NOTE: Suspend further checks
-            return;
-          }
+          aInnerCallback(null); // NOTE: Suspend further checks
+          return;
           // /Workaround for #1323
 
           fn.get(URL.parse(icon), function (aRes) {