Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Netty 4.x #66

Open
dingwa opened this issue Aug 16, 2013 · 6 comments
Open

Support Netty 4.x #66

dingwa opened this issue Aug 16, 2013 · 6 comments

Comments

@dingwa
Copy link

dingwa commented Aug 16, 2013

Netty 4.x is now out and it would be good to have asynchbase support this. The Netty APIs have significantly changed so some plan will need to be put in place to support both Netty 4.x and 3.x?

@tsuna
Copy link
Member

tsuna commented Apr 4, 2014

How can we support both Netty 4.x and Netty 3.x?

My guess is that since going to Netty 4.x will break some of the AsyncHBase APIs, we'll have to jump to AsyncHBase 2.0 for this migration to happen. Are you willing to help change all the Netty code?

@dingwa
Copy link
Author

dingwa commented Apr 5, 2014

Yes I'm thinking the same way.

Yes for sure. I'll start looking around the code in more detail to get more familiar.

@tsuna
Copy link
Member

tsuna commented Apr 5, 2014

Awesome. But yeah I definitely agree we need to move to Netty 4.x, I just don't have the bandwidth to make the change (as you can tell from the amount of time it took me to follow up on this issue). If you want to take a lead and make it happen, please do.

@dingwa
Copy link
Author

dingwa commented Apr 5, 2014

Unfortunately bandwidth on my side is minimal as well. However Netty 4.x should be in very stable state to warrant the move up. Let me have a look at it over time, unfortunately I can't give you timelines to when I can get this done. But I'll keep you posted (hopefully with some code!)

@tsuna
Copy link
Member

tsuna commented Apr 5, 2014

It's OK, I totally understand everything we're all doing for AsyncHBase is on a "best effort" basis. Whoever sends a pull request first wins :)

@ooasis
Copy link

ooasis commented Mar 9, 2016

PR #116 has been submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants