-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parameter validation for input_fields #907
Conversation
@lucassz This looks good. Can you add a test demonstrating the validation behavior? There aren't any specific tests for the forms. You can create a new file You can look to |
@hdoupe Done. It seemed more relevant to add it to |
@@ -57,6 +57,20 @@ def test_taxbrain_post(self, data_source): | |||
check_posted_params(result['tb_dropq_compute'], truth_mods, | |||
str(START_YEAR), data_source=data_source) | |||
|
|||
@pytest.mark.xfail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucassz This shouldn't be xfail-ed. That means that py.test
will ignore it if the test fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdoupe Thank you. I think I had understood the purpose of xfail
.
@lucassz This looks great. Thanks for taking care of this and for finding a much simpler way to solve the problem. |
@lucassz This should be good to go once you knock out the merge conflicts. |
@hdoupe Happy to do it. Should be good to go now. |
Great, thanks @lucassz |
Implement parameter validation for input_fields, both for TaxBrain and for the partial equilibrium model.